Implement leaderelection type getter via restmapper #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszostok
commented
Sep 21, 2019
| @@ -36,6 +36,9 @@ import ( | |||
| func NewDiscoveryRESTMapper(c *rest.Config) (meta.RESTMapper, error) { | |||
| // Get a mapper | |||
| dc := discovery.NewDiscoveryClientForConfigOrDie(c) | |||
|
|
|||
| // TODO(mszostok): here we have useful info about all supported groups and resource | |||
| // in api-server | |||
| gr, err := restmapper.GetAPIGroupResources(dc) | |||
There was a problem hiding this comment.
here we have info about all supported groups that we could use for checking if Lease is available, but it's not exposed, so I decided to use the RESTMapping method from mapper and assert error via IsNoMatchError
mszostok
force-pushed
the
alternative-ver
branch
2 times, most recently
from
b671ff2
to
1fe47fc
Compare
mszostok
force-pushed
the
alternative-ver
branch
from
1fe47fc
to
6c0f6c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is just draft to show the implementation of leaderelection type getter via restmapper. With such implementation we are not calling the api-sever to get all supported groups